-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation. #18
Conversation
your iDRAC/iLO host, and save its result to Ralph (at this moment, it will be | ||
limited only to MAC addresses, but that is going to change soon!). | ||
|
||
## Getting ralph-cli binary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please separate development and end user installation methods. glide should not be known for the EU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Getting ralph-cli binary/Installation
The binary is not a task, but implementation detail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I'll separate these two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw i'll consider naming this section 'Installation' (i know that downloading binary is not a installation per se, but it could be more familiar to the user when he'll see headers of the docs than 'Getting ralph-cli binary')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about separating end user install and development install, IMO there should be separated page about development of (contributing to?) ralph cli.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as I have mentioned previously, I'll separeate these two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM |
🆗 |
@mkurek + @vi4m - please have a look at this PR. For your convenience, the rendered version of these docs is available here.