DNS records from DNSAAS. #2289
Merged
DNS records from DNSAAS. #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| DNS_AUTO_PTR_ALWAYS = 2 | ||
| DNS_AUTO_PTR_NEVER = 1 |
|
please add basic documentation (docs) for dnsaas integration - possible settings. Put a note here, that this is not transaction-safe, since it's communicating with external system through the api. |
| - ``ENABLE_DNSAAS_INTEGRATION`` - set to True if you want to enable DNSaaS integration | ||
| - ``DNSAAS_URL`` - Url to DNSAAS | ||
| - ``DNSAAS_TOKEN`` - API Token to DNSAAS | ||
| - ``DNS_AUTO_PTR_ALWAYS`` - DNSAAS auto_ptr value, default is 2 |
There was a problem hiding this comment.
DNS_AUTO_PTR_ALWAYS -> DNSAAS_AUTO_PTR_ALWAYS?
ghost
ghost
changed the title
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def get_api_kwargs(url, data=None, headers=None): |
There was a problem hiding this comment.
please move all *_api_* and *_dns_* method to class and separated module like dnsass.py
Added optional DNS feature to data center assets. See: https://github.com/allegro/django-powerdns-dnssec
| if result: | ||
| return result[0]['url'] | ||
|
|
||
| def create_dns_records(self, record): |
There was a problem hiding this comment.
create_dns_records or create_dns_record ?
Change method name in DNSAAS api
…d in view * Now you could use `skip_first` param in cache decorator - when set to True, first param (usually class instance a.k.a self) will not be used to calculate hash of params * dnsview not checks if dnsaas integration is enabled
Added `skip_first` to cache and check if dnsaas integration is enabled in view
|
🆗 |
1 similar comment
|
🆗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional DNS feature to data center assets.
See: https://github.com/allegro/django-powerdns-dnssec