ignore zero value usages #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymi-
requested review from
ar4s,
MarekBleschke,
mkurek and
vi4m
as code owners
szymi-
commented
Aug 21, 2018
| @@ -1264,6 +1300,7 @@ def test_pricing_service_usage_api_endpoint_with_filtering_by_service(self): # | |||
| self.assertEquals(resp.status_code, 200) | |||
| received_response = json.loads(resp.content) | |||
| usages = received_response['usages'] | |||
| usages.sort() | |||
There was a problem hiding this comment.
This test was failing randomly - sorting usages fixes it.
mkurek
reviewed
Aug 21, 2018
| ) | ||
| daily_usages.append(daily_usage) | ||
| usages_daily_pricing_objects[usage_type].append( | ||
| daily_pricing_object | ||
| ) |
There was a problem hiding this comment.
shouldn't this line be indented by 4 more spaces?
mkurek
approved these changes
Aug 21, 2018
mkurek
added a commit
that referenced
this pull request
Dec 4, 2018
…y usages When pricing service has multiple services (for distributing cost) and not every DailyUsage is present (see #648 - ignoring zero-value usage) costs were not distributed properly. It was caused by storying usage values for single service environment on lists - these lists have different size and when accessing by index (and using `zip` to join this list with total usage and percentage for usage type) usage value was combined with wrong total usage and percentage.
mkurek
added a commit
that referenced
this pull request
Dec 5, 2018
…y usages (#652) When pricing service has multiple services (for distributing cost) and not every DailyUsage is present (see #648 - ignoring zero-value usage) costs were not distributed properly. It was caused by storying usage values for single service environment on lists - these lists have different size and when accessing by index (and using `zip` to join this list with total usage and percentage for usage type) usage value was combined with wrong total usage and percentage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.