Fix distributing pricing service cost when there is lack of some daily usages #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y usages When pricing service has multiple services (for distributing cost) and not every DailyUsage is present (see #648 - ignoring zero-value usage) costs were not distributed properly. It was caused by storying usage values for single service environment on lists - these lists have different size and when accessing by index (and using `zip` to join this list with total usage and percentage for usage type) usage value was combined with wrong total usage and percentage.
vi4m
reviewed
Dec 5, 2018
| # create hierarchy basing on usages | ||
| for (po, se), po_usages in usages.items(): | ||
| po_usages_info = zip(po_usages, total_usages, percentage) | ||
| po_usages_info = [ |
There was a problem hiding this comment.
+1, IMO using full names for po, ut, se would be more readable for future us ;)
There was a problem hiding this comment.
sure - i've expanded all abbreviations here
| po_usages_info = zip(po_usages, total_usages, percentage) | ||
| po_usages_info = [ | ||
| (value, total_usages[ut_id], percentage[ut_id]) | ||
| for ut_id, value in po_usages.items() |
There was a problem hiding this comment.
what does ut mean? usage_type?
There was a problem hiding this comment.
yes - it's explained now
szymi-
approved these changes
Dec 5, 2018
MarekBleschke
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pricing service has multiple services (for distributing cost) and
not every DailyUsage is present (see #648 - ignoring zero-value usage)
costs were not distributed properly. It was caused by storying usage
values for single service environment on lists - these lists have
different size and when accessing by index (and using
ziptojoin this list with total usage and percentage for usage type)
usage value was combined with wrong total usage and percentage.