Feature/manifest parser #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 12, 2016 17:55
# Conflicts: # slinger/src/main/java/pl/allegro/android/slinger/IntentStarter.java
Current coverage is
|
| try { | ||
| ActivityInfo activityInfo = activity.getPackageManager() | ||
| .getActivityInfo(new ComponentName(activity.getPackageName(), | ||
| "pl.allegro.android.slinger.SlingerActivity"), PackageManager.GET_META_DATA); |
There was a problem hiding this comment.
hmmm, activity.getClass().getCanonicalName()?
| "You cannot run this Activity without specifying Uri inside Intent!"); | ||
| } | ||
|
|
||
| excludeSlingerAndStartTargetActivity(parentActivity, |
There was a problem hiding this comment.
any way to reformat this to improve readability?
extract method results to parameters?
| @@ -15,6 +15,12 @@ android { | |||
| sourceCompatibility JavaVersion.VERSION_1_7 | |||
| targetCompatibility JavaVersion.VERSION_1_7 | |||
| } | |||
| buildTypes { | |||
| release { | |||
| minifyEnabled true | |||
There was a problem hiding this comment.
I think that you need some proguard rules here, at least for the Android classes.
There was a problem hiding this comment.
It's not needed. Plugin add them on t's own.
|
👍 |
1 similar comment
|
👍 |
| @@ -41,7 +42,7 @@ ext { | |||
| minSdkVersion = 9 | |||
| targetSdkVersion = 23 | |||
|
|
|||
| supportAnnotations = 'com.android.support:support-annotations:23.0.0' | |||
| supportAnnotations = 'com.android.support:support-annotations:23.1.1' | |||
added 11 commits
May 12, 2016 14:31
This reverts commit 1001565.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.