Add spanish support #111
Merged
Add spanish support #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, tomorrow I will look at your PR :) |
|
Oh, sorry, I was busy and forgot to check your PR. @bartlomiejgraczyk will review your code. |
jglaszka
reviewed
Sep 6, 2023
src/main/java/pl/allegro/finance/tradukisto/MoneyConverters.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public String currency() { | ||
| return "$"; |
There was a problem hiding this comment.
I think it should be €, as it is official currency for Spain
src/main/java/pl/allegro/finance/tradukisto/internal/Container.java
Outdated
Show resolved
Hide resolved
bartlomiejgraczyk
requested changes
Sep 8, 2023
README.md
Outdated
Comment on lines
37
to
42
| * 🇸🇰 Slovak | ||
| * 🇺🇦 Ukrainian | ||
| * 🇷🇸 Serbian (Latin) | ||
| * 🇷🇸 Serbian (Cyrillic) | ||
| * 🇸🇰 Slovak | ||
| * 🇪🇸 Spanish | ||
| * 🇹🇷 Turkish | ||
| * 🇺🇦 Ukrainian |
src/main/java/pl/allegro/finance/tradukisto/internal/Container.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/spanish/SpanishValues.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/spanish/SpanishValues.java
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/Container.java
Outdated
Show resolved
Hide resolved
...pl/allegro/finance/tradukisto/internal/languages/spanish/SpanishIntegerToWordsConverter.java
Outdated
Show resolved
Hide resolved
...l/allegro/finance/tradukisto/internal/languages/spanish/SpanishThousandToWordsConverter.java
Outdated
Show resolved
Hide resolved
...l/allegro/finance/tradukisto/internal/languages/spanish/SpanishThousandToWordsConverter.java
Outdated
Show resolved
Hide resolved
...l/allegro/finance/tradukisto/internal/languages/spanish/SpanishThousandToWordsConverter.java
Outdated
Show resolved
Hide resolved
...l/allegro/finance/tradukisto/internal/languages/spanish/SpanishThousandToWordsConverter.java
Outdated
Show resolved
Hide resolved
|
Hi @luismateoh, we added some comments for you in review. Can you take a look? |
# Conflicts: # README.md # src/main/java/pl/allegro/finance/tradukisto/MoneyConverters.java # src/main/java/pl/allegro/finance/tradukisto/ValueConverters.java # src/main/java/pl/allegro/finance/tradukisto/internal/Container.java
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #111 +/- ##
============================================
- Coverage 99.19% 98.46% -0.73%
- Complexity 425 473 +48
============================================
Files 67 71 +4
Lines 1736 1895 +159
Branches 50 73 +23
============================================
+ Hits 1722 1866 +144
- Misses 7 17 +10
- Partials 7 12 +5
|
|
I carried out most of the suggestions you made, I appreciate the comments you made and agree with them |
Closed
bartlomiejgraczyk
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented
Integerconverter for spanish.Could you kindly take a look at this pull request? I'm available for discussions.