-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hindi support #112
Added hindi support #112
Conversation
Fixes issue number #112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It need to have higher tests' coverage - I created unit tests (see my comment in LongValueConvertersTest.groovy) what can be copied, updated to correct forms in hindi and used in your PR. Also there are a few small comments for the code syntax.
src/main/java/pl/allegro/finance/tradukisto/ValueConverters.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/Container.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/hindi/HindiPluralForms.java
Outdated
Show resolved
Hide resolved
src/test/groovy/pl/allegro/finance/tradukisto/LongValueConvertersTest.groovy
Show resolved
Hide resolved
src/test/groovy/pl/allegro/finance/tradukisto/LongValueConvertersTest.groovy
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/hindi/HindiValues.java
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/support/IndianNumberChunking.java
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/Container.java
Outdated
Show resolved
Hide resolved
...egro/finance/tradukisto/internal/languages/hindi/HindiBigDecimalToBankingMoneyConverter.java
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/hindi/HindiValues.java
Show resolved
Hide resolved
Resolved the comments. I think we should use auto formatter in build to avoid formatting differences in MRs. |
@jglaszka MR has been updated |
Added Hindi Numbers Support
Added Specialized Indian Chunking implementation to support all Indian languages.
Added test cases for all three types.