Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added hindi support #112

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Added hindi support #112

merged 2 commits into from
Sep 5, 2023

Conversation

girdharsourabh
Copy link
Contributor

Added Hindi Numbers Support
Added Specialized Indian Chunking implementation to support all Indian languages.
Added test cases for all three types.

@girdharsourabh
Copy link
Contributor Author

Fixes issue number #112

@jglaszka jglaszka self-requested a review August 29, 2023 18:26
jglaszka
jglaszka requested changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@jglaszka jglaszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It need to have higher tests' coverage - I created unit tests (see my comment in LongValueConvertersTest.groovy) what can be copied, updated to correct forms in hindi and used in your PR. Also there are a few small comments for the code syntax.

src/main/java/pl/allegro/finance/tradukisto/ValueConverters.java Outdated Show resolved Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/Container.java Outdated Show resolved Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/hindi/HindiPluralForms.java Outdated Show resolved Hide resolved
src/test/groovy/pl/allegro/finance/tradukisto/LongValueConvertersTest.groovy Show resolved Hide resolved
src/test/groovy/pl/allegro/finance/tradukisto/LongValueConvertersTest.groovy Show resolved Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/hindi/HindiValues.java Show resolved Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/support/IndianNumberChunking.java Show resolved Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/Container.java Outdated Show resolved Hide resolved
...egro/finance/tradukisto/internal/languages/hindi/HindiBigDecimalToBankingMoneyConverter.java Show resolved Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/hindi/HindiValues.java Show resolved Hide resolved
@jglaszka jglaszka mentioned this pull request Aug 30, 2023
Open
@girdharsourabh
Copy link
Contributor Author

Resolved the comments. I think we should use auto formatter in build to avoid formatting differences in MRs.

@girdharsourabh
Copy link
Contributor Author

@jglaszka MR has been updated

@jglaszka jglaszka removed the in review label Sep 5, 2023
@jglaszka jglaszka enabled auto-merge (squash) September 5, 2023 18:30
@jglaszka jglaszka merged commit 3cd5170 into allegro:master Sep 5, 2023
@jglaszka jglaszka mentioned this pull request Sep 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglaszka jglaszka jglaszka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@girdharsourabh @jglaszka