Add Croatian support #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglaszka
approved these changes
Jul 4, 2023
jglaszka
reviewed
Jul 4, 2023
| } | ||
|
|
||
| private boolean useSingular(Integer value) { | ||
| return value == 1 || (value % 100 != 11 && value % 10 == 1); |
There was a problem hiding this comment.
I see that identical logic is in other slavic languages - russian, ukrainian, bulgarian - so this class in future could be refactored into shared one class. In polish 121 000 000 is plural (sto dwadzieścia jeden milionów), because for polish people every number over 1 is plural. It looks that in other slavic languages numbers ending on 1 (but not 11) is singular:
- HR: sto dvadeset jedan milijun
- RU: сто двадцать один миллион
- UK: сто двадцять один мільйон
So I think we could move polish code into PolishPluralForms and other slavic into SlavonicPluralForms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Croatian support