Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the slavic languages can share class PluralForms #95

Closed
jglaszka opened this issue Jul 4, 2023 · 1 comment
Closed

Some of the slavic languages can share class PluralForms #95

jglaszka opened this issue Jul 4, 2023 · 1 comment

Comments

@jglaszka
Copy link
Collaborator

jglaszka commented Jul 4, 2023

copied from #65 (comment):
I see that identical logic is in other slavic languages - russian, ukrainian, bulgarian - so this class in future could be refactored into shared one class. In polish 121 000 000 is plural (sto dwadzieścia jeden milionów), because for polish people every number over 1 is plural. It looks that in other slavic languages numbers ending on 1 (but not 11) is singular:

HR: sto dvadeset jedan milijun
RU: сто двадцать один миллион
UK: сто двадцять один мільйон
So I think we could move polish code into PolishPluralForms and other slavic into SlavonicPluralForms.

@jglaszka
Copy link
Collaborator Author

jglaszka commented Jul 4, 2023

I updated the test cases in https://github.com/allegro/tradukisto/pull/97/files to ensure that test cases have adequate coverage and it will detect possible regression in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant