Skip to content

Commit

Permalink
Build on the latest Node 14.x and 16.x (#956)
Browse files Browse the repository at this point in the history
  • Loading branch information
mkuthan committed Nov 24, 2022
1 parent 867df8a commit ef0d21a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Setup build
inputs:
node-version:
required: true
default: '16.15.0'
default: '16'
description: Node version

runs:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

strategy:
matrix:
node-version: [14.20.0, 16.15.0]
node-version: ['14', '16']

steps:
- uses: actions/checkout@v3
Expand All @@ -40,7 +40,7 @@ jobs:

strategy:
matrix:
node-version: [14.20.0, 16.15.0]
node-version: ['14', '16']

steps:
- uses: actions/checkout@v3
Expand Down
3 changes: 1 addition & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#
# BUILD stage
# Use last supported node version (16.15.0) for build
#
FROM node:16.15.0 AS build
FROM node:16 AS build

WORKDIR /usr/src/app

Expand Down
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ or join the chat on [Slack](https://join.slack.com/t/turnilo/shared_invite/enQtO

* [Node.js](https://nodejs.org/) - 14.x or 16.x version

:warning:
We test builds with 14.20.0 and 16.15.0

:warning:
Do not use `yarn` command for dependency management and project build, use `npm` instead.
With `npm` builds are reproducible (thanks to package-lock.json) and even faster than with `yarn`.
Expand Down

0 comments on commit ef0d21a

Please sign in to comment.