Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove qajax，use fetch（or axios）instead #51

Closed
beibm opened this issue Feb 26, 2018 · 2 comments
Closed

remove qajax，use fetch（or axios）instead #51

beibm opened this issue Feb 26, 2018 · 2 comments
Labels
technical debt

Comments

@beibm
Copy link

beibm commented Feb 26, 2018

qajax is now a dead project，use fetch or axios instead it！
@piter75
Copy link
Contributor

piter75 commented Feb 26, 2018

Thanks for reporting. That one is on our radar too.
We will take a closer look into that while working on #19.

@milimetric
Copy link
Contributor

I'm looking at #19 now, seems like the easiest way is just to remove the qajax dependency and fix all the problems :) I'll start that way and see where I end up.

milimetric added a commit to milimetric/turnilo that referenced this issue Nov 23, 2018
@milimetric
Remove qajax, use axios consistently
3d84168 
So far, replaced Qajax, removed the dependency, checked that tests
aren't failing, and checked the interface superficially.  Next step is
to replace Q.Promise.

Looked into using fetch but a custom timeout and conversion of the
response to json is required, both of which axios does easily.  We could
implement these on top of fetch, but it seems cleaner this way.

The pull request that this commit will be part of works on allegro#19 and allegro#51

NOTE: axios is promising some good improvements in 0.19 but it's been
stuck in beta for a few months with no activity moving towards release.
@milimetric milimetric mentioned this issue Nov 23, 2018
Closed
milimetric added a commit to milimetric/turnilo that referenced this issue Dec 21, 2018
@milimetric
Refactor uses of q to native Promise
a3b98a8 
This is a big refactor, so I'm pushing the first thing that builds, this
way people can see what's affected and let me know how to proceed.  My
next steps would be to test thoroughly, and I'm open to other ideas.
Let's work together to land this soon before it trips up on other
changes.

Ongoing work on allegro#19 and allegro#51.
@mkuthan mkuthan closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@piter75 @milimetric @mkuthan @beibm