Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply time shift period filter after counting whole expression #737

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Apply time shift period filter after counting whole expression #737

merged 2 commits into from
Apr 22, 2021

Conversation

adrianmroz-allegro
Copy link
Contributor

Closes #673

@adrianmroz-allegro adrianmroz-allegro added this to In progress in 1.32 via automation Apr 21, 2021
1.32 automation moved this from In progress to Reviewer approved Apr 21, 2021
mkuthan
mkuthan approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@mkuthan mkuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever, if it really works.

@adrianmroz-allegro
Copy link
Contributor Author

Yeah, it is much simpler and as far I could reproduce #673 - it works. I compared Two hours splitted and One hour with time shift and it checks out.

@adrianmroz-allegro adrianmroz-allegro marked this pull request as ready for review April 21, 2021 14:56
@adrianmroz-allegro adrianmroz-allegro mentioned this pull request Apr 21, 2021
Closed
@adrianmroz-allegro adrianmroz-allegro merged commit e83afb7 into master Apr 22, 2021
1.32 automation moved this from Reviewer approved to Done Apr 22, 2021
@adrianmroz-allegro adrianmroz-allegro deleted the bugfix/apply-time-period-later branch April 22, 2021 08:39
@rshkarin rshkarin mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuthan mkuthan mkuthan approved these changes

Assignees
No one assigned
Labels
bug
Projects
No open projects
1.32
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculated metrics incorrect with time shift
2 participants
@adrianmroz-allegro @mkuthan