Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow dataset image to be empty #123

Merged
merged 1 commit into from
Jan 4, 2023
Merged

allow dataset image to be empty #123

merged 1 commit into from
Jan 4, 2023

Conversation

toloudis
Copy link
Contributor

@toloudis toloudis commented Jan 3, 2023

Problem

Variance datasets were decided to have no thumbnail preview image on the main cards on the landing page.

Solution

Simply omit image if it's an empty string.

Cell Feature Explorer 2023-01-03 13-14-14

Type of change

  • New feature (non-breaking change which adds functionality)

@toloudis toloudis requested a review from meganrm as a code owner January 3, 2023 21:19
@toloudis toloudis requested a review from frasercl January 3, 2023 21:20
@toloudis toloudis merged commit 8689b92 into main Jan 4, 2023
@toloudis toloudis deleted the feature/allow-dataset-card-no-picture branch January 4, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganrm meganrm Awaiting requested review from meganrm

@frasercl frasercl Awaiting requested review from frasercl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@toloudis