Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to save the highlighted/selected multiple tabs ! #13

Closed
dnknn opened this issue Feb 18, 2021 · 9 comments
Closed

Add to save the highlighted/selected multiple tabs ! #13

dnknn opened this issue Feb 18, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dnknn
Copy link

dnknn commented Feb 18, 2021

Save for later referred to as SFL.

Feature request: SFL can support to selected/highlighted multiple tabs with holding Ctrl/Shift !

I don't know if you know this browser basic feature ?

Click to view: What is the selected/highlighted multiple tabs ❓

multi-selected-tabs

  1. You can try to holdding Ctrl/Shift/Ctrl+Shift on the tab-bar and click the non-current tab.
  2. At this point, you have selected multiple tabs at the same time.
  3. Finally, you can perform batch operations on these selected tabs. e.g. Ctrl+W to batch closes them, F5 to batch reload them ... can also drag them in batches. etc...

Example extension : (In fact, many extensions support this feature)

  • So can you support for this browser kernel/API function (the 🔌 highlighted API can be used directly)

I don't know if it is this API-Doc :
https://developer.chrome.com/docs/extensions/reference/tabs/#event-onHighlighted


  • Current behavior:

  SFL can only save all tabs in the window , which is very limited!
  More often, users only want to save the selected/highlighted tabs with holding Ctrl/Shift (⚠In fact, the current tab is also selected/highlighted , it's just 1)

  • Expected behavior:

  When the multiple tabs be selected/highlighted with holding Ctrl/Shift/Ctrl+Shift,
At this time, it becomes an operation for the selected multiple tabs,
that is, at this time, it cannot remain as an operation for the current tab/page.

  • To sum up a sentence:
    SFL it can support for selected/highlighted multiple tabs with holding Ctrl/Shift/Ctrl+Shift.

💡 Implementation plan : see 👇

212_18150240


Whatever, must support this very smart/convenient/perfect feature, as for the UI/GUI is up to you ... ^_^


  • ⚠ Of course, this function 👇 must also support the hotkey operating!

#12


💪👍 If can be achieved, will be perfect + very smart!

This was referenced Feb 18, 2021
@allen505
Copy link
Owner

allen505 commented Feb 19, 2021

Hi @dnknn . Thanks for the suggestion.
I wouldn't call this as a "biggest problem" with SFL😀 . This changes should be fairly easy to do. My idea for such a feature is to not add a new button, but just checking if there are tabs selected, and if it is, then only those selected tabs they will be saved, silently.

To implement this feature we need to use the highlighted condition in this line.
Reference: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/Tab

@allen505 allen505 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 19, 2021
@allen505 allen505 added this to Planned ideas in Features/Issues Pipeline via automation Feb 19, 2021
@allen505 allen505 moved this from Planned ideas to Scheduled for next version in Features/Issues Pipeline Feb 19, 2021
@dnknn
Copy link
Author

dnknn commented Feb 19, 2021

My idea for such a feature is to not add a new button, but just checking if there are tabs selected, and if it is, then only those selected tabs they will be saved, silently.

💪👍 Yes, Great idea! Be smarter and keep lightweight!

To implement this feature we need to use the highlighted condition in this line.

I don't understand the code 🤦

@dnknn dnknn changed the title SFL has one biggest problem : Does not saving the highlighted/selected multiple tabs Add to save the highlighted/selected multiple tabs ! Feb 19, 2021
@dnknn
Copy link
Author

dnknn commented Feb 20, 2021

@allen505

My idea for such a feature is to not add a new button, but just checking if there are tabs selected, and if it is, then only those selected tabs they will be saved, silently.

  • But here comes the question, what if the user only wants to save the current 1 tab ?

So you should add options like this: ⬜ If there are no highlighted tabs, the default behavior is to save the current window ? or the current tab ? , this option can perfectly solve this problem!


If follow your current point of view, then the following :

  • 💥 Current behavior:

   Save the current window or highlighted tabs, but cannot save the current 1 tab, This still means, unwanted tabs will be forced to be saved (If you don’t select ⩾2 tabs)

  • Expected Default/Optional behavior:

   Save the current 1 tab or highlighted/selected multiple tabs.

@allen505
Copy link
Owner

I don't understand the code

I added it for a future reference when anyone works on this. I should've made a separate comment.

You bring up a valid issue. So my thinking is that saving a single tab should not be possible at all, not even as a settings option. The reasoning behind it is that saving a single tab is done by using Bookmarks. This extension should be used to save multiple tabs or an entire window.

@dnknn
Copy link
Author

dnknn commented Feb 20, 2021

saving a single tab should not be possible at all

The reasoning behind it is that saving a single tab is done by using Bookmarks.

This extension should be used to save multiple tabs or an entire window.

Different usage scenarios, The positioning of this extension is to read later , It means to delete it after reading it, and bookmarks are similar to permanent storage.

If you want to save multiple tabs, there are too many ways to implement it even without this extension, and you can even copy the URLs of multiple tabs and save them elsewhere, so I hope you think about it.

In other words, users can use this extension as a temporarily saved scene, temporarily saved, or called temporary storage first

@dnknn
Copy link
Author

dnknn commented Feb 20, 2021

@allen505 I think a single tab save is also save!

There are also many users who do not display the bookmark-bar (Ctrl+Shift+B),
Think about it: Will you save a temporary single tab as a bookmark? Come over and read it like delete it?

The key issue is that bookmarks are administrative in nature, and the extension should be positioned as casual and temporary. Of course, personal opinion...you decide ^_^


In addition, the main reason I chose the extension is that the page is not closed when saving, And lightweight / miniaturization , Very much in line with the name of the extension "Save for later " , i.e. Fast/easy to 💾save, and Fast/easy to 🗑delete.

When need to close the page after save, I will switch to better-onetab extension (Can save single or multiple) or Panic Button extension.

So the positioning/function of each extension is different.

@allen505
Copy link
Owner

I still feel that highlight and save for a single tab is not necessary and that it is a rare occurrence. On such occasions you can separate the single tab into a separate window by pulling it out of the current window and saving the newly created window. This way the single tab can be easily created.

Features/Issues Pipeline automation moved this from Scheduled for next version to Done Feb 20, 2021
@allen505
Copy link
Owner

I have implemented this feature in my latest commit. If you wish to test the new version locally please follow these instructions.

@allen505 allen505 removed the help wanted Extra attention is needed label Feb 20, 2021
@dnknn
Copy link
Author

dnknn commented Feb 20, 2021

I have implemented this feature in my latest commit

Thank you very much!!!

The test results are very good, in line with expectations, and enough! The single tab is up to you !

@allen505 allen505 self-assigned this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants