-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to save the highlighted/selected multiple tabs ! #13
Comments
Hi @dnknn . Thanks for the suggestion. To implement this feature we need to use the |
💪👍 Yes, Great idea! Be smarter and keep lightweight!
I don't understand the code 🤦 |
So you should add options like this: ⬜ If there are no If follow your current point of view, then the following :
Save the current window or
Save the current 1 tab or |
I added it for a future reference when anyone works on this. I should've made a separate comment. You bring up a valid issue. So my thinking is that saving a single tab should not be possible at all, not even as a settings option. The reasoning behind it is that saving a single tab is done by using Bookmarks. This extension should be used to save multiple tabs or an entire window. |
Different usage scenarios, The positioning of this extension is to read later , It means to delete it after reading it, and bookmarks are similar to permanent storage. If you want to save multiple tabs, there are too many ways to implement it even without this extension, and you can even copy the URLs of multiple tabs and save them elsewhere, so I hope you think about it. In other words, users can use this extension as a temporarily saved scene, temporarily saved, or called temporary storage first |
@allen505 I think a single tab save is also save!There are also many users who do not display the bookmark-bar ( The key issue is that bookmarks are administrative in nature, and the extension should be positioned as casual and temporary. Of course, personal opinion...you decide ^_^ In addition, the main reason I chose the extension is that the page is not closed when saving, And lightweight / miniaturization , Very much in line with the name of the extension "Save for later " , i.e. Fast/easy to 💾save, and Fast/easy to 🗑delete. When need to close the page after save, I will switch to better-onetab extension (Can save single or multiple) or Panic Button extension. So the positioning/function of each extension is different. |
I still feel that highlight and save for a single tab is not necessary and that it is a rare occurrence. On such occasions you can separate the single tab into a separate window by pulling it out of the current window and saving the newly created window. This way the single tab can be easily created. |
I have implemented this feature in my latest commit. If you wish to test the new version locally please follow these instructions. |
Thank you very much!!! The test results are very good, in line with expectations, and enough! The single tab is up to you ! |
Feature request: SFL can support to selected/highlighted multiple tabs with holding Ctrl/Shift !
I don't know if you know this browser basic feature ?
Click to view: What is the selected/highlighted multiple tabs ❓
Example extension : (In fact, many extensions support this feature)
better-onetab
https://chrome.google.com/webstore/detail/eookhngofldnbnidjlbkeecljkfpmfpg
https://github.com/cnwangjie/better-onetab
SingleFile
https://chrome.google.com/webstore/detail/mpiodijhokgodhhofbcjdecpffjipkle
http://github.com/gildas-lormeau/SingleFile
https://chrome.google.com/webstore/detail/micdllihgoppmejpecmkilggmaagfdmb
highlighted
API can be used directly)I don't know if it is this API-Doc :
https://developer.chrome.com/docs/extensions/reference/tabs/#event-onHighlighted
Current behavior:
SFL can only save all tabs in the window , which is very limited!
More often, users only want to save the selected/highlighted tabs with holding Ctrl/Shift (⚠In fact, the current tab is also selected/highlighted , it's just 1)
Expected behavior:
When the multiple tabs be selected/highlighted with holding Ctrl/Shift/Ctrl+Shift,
At this time, it becomes an operation for the selected multiple tabs,
that is, at this time, it cannot remain as an operation for the current tab/page.
SFL it can support for selected/highlighted multiple tabs with holding Ctrl/Shift/Ctrl+Shift.
💡 Implementation plan : see 👇
Whatever, must support this very smart/convenient/perfect feature, as for the UI/GUI is up to you ... ^_^
#12
💪👍 If can be achieved, will be perfect + very smart!
The text was updated successfully, but these errors were encountered: