Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightweight HF integration #220
Lightweight HF integration #220
Changes from 27 commits
442f86c
c7c170d
2befdc5
b5da6b4
6935e5f
5b623fc
bdbf041
e6df083
6db6980
c3611d7
71abd14
c92f25e
e0fd0a7
bfa379f
754eff1
9e7b57c
6159097
126e5a5
7c8243d
7abd90f
e4c14a6
e5f91a3
d5006a5
72248f0
89aaf97
9659955
833e4f5
1a4ba1b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add another job to run the HF tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline: since this requires updating the beaker image on which we run the GPU tests, and since we expect to reconfigure this at some point, it's not worth the effort now.
I've confirmed using instruct-eval that the HF integration runs on GPU.