Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait on all ranks until final ckpt dir exists #235

Merged
merged 2 commits into from
Jul 20, 2023
Merged

wait on all ranks until final ckpt dir exists #235

merged 2 commits into from
Jul 20, 2023

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Jul 19, 2023

See #234.

@epwalsh epwalsh mentioned this pull request Jul 19, 2023
Open
@epwalsh epwalsh requested review from dirkgr and drschwenk July 19, 2023 23:44
@drschwenk
Copy link
Contributor

drschwenk commented Jul 19, 2023 •
edited
Loading

Ah, ok that looks good.

Do we need to set a timeout limit, or will a condition that prevents this dir from existing lead to an exit elsewhere?

@dirkgr
Copy link
Member

dirkgr commented Jul 20, 2023

Timeout would be good.

@epwalsh
Copy link
Member Author

epwalsh commented Jul 20, 2023

TImeout added: b4fdc6f

@drschwenk
Copy link
Contributor

This looks good to me.

@epwalsh epwalsh merged commit 907e38b into main Jul 20, 2023
10 checks passed
@epwalsh epwalsh deleted the petew-nfs-checkpoint branch July 20, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkgr dirkgr Awaiting requested review from dirkgr

@drschwenk drschwenk Awaiting requested review from drschwenk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epwalsh @drschwenk @dirkgr