Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hf_olmo modeling class should be a true PreTrainedModel #391

Merged
merged 13 commits into from
Dec 9, 2023
Merged

Conversation

AkshitaB
Copy link
Contributor

@AkshitaB AkshitaB commented Dec 7, 2023

This is necessary for loading and finetuning further.

There is some degree of code repetition between olmo and hf_olmo which I would have liked to avoid, but it was leading to odd issues in loading the state dict.

hf_olmo/modeling_olmo.py Outdated Show resolved Hide resolved
def tie_weights(self):
if self.config.weight_tying:
self.model.transformer.ff_out = self.model.transformer.wte


# Register the model so that it is available for transformer pipelines, auto-loading, etc.
AutoModelForCausalLM.register(OLMoConfig, OLMoForCausalLM)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested multi-gpu loading? e.g.
AutoModelForCausalLM.from_pretrained(..., device_map='balanced') with multiple GPUs available?

And does generation work fine?

@AkshitaB AkshitaB merged commit e99dbe5 into main Dec 9, 2023
10 checks passed
@AkshitaB AkshitaB deleted the hf-olmo-new branch December 9, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants