Cherry-pick FSDP wrap patch from #443 #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the FSDP wrapping function, the "recurse" mode does not behave as expected (for large models anyway). In particular it seems like there's an inherent "sized-based" policy being applied that ignores our intent to stop recursing down the module tree at, for example, the level of an transformer block. The API for wrapping functions itself is pretty simple, so I can't imagine how we'd be interpreting it wrong. I suspect this another FSDP bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the FSDP wrapping function, the "recurse" mode does not behave as
expected (for large models anyway). In particular it seems like there's
an inherent "sized-based" policy being applied that ignores our intent
to stop recursing down the module tree at, for example, the level of an
transformer block.
The API for wrapping functions itself is pretty simple, so I can't imagine how we'd
be interpreting it wrong. I suspect this another FSDP bug.