Nanna arm camera remove #1041
Merged
Nanna arm camera remove #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh interesting, it was still rendering even when disabled? Can we benchmark this on the python side? Perhaps run this build against the version before it was removed and a version where it's just disabled and compare FPS? |
|
I am not sure if it is rendering when disabled on the standalone release, reading about it should not render. In the editor it still shows a preview window for the camera even when disabled so I decided to go with the safer approach for the quick fix. I think we should merge this as the initial fix, and do the benchmarking for investigation since it's slightly unrelated and more about understanding Unity's general rules for camera components. |
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Camera component from GripperCamera Prefab, disabling Component seemed to still render at least in Editor so removed after checking for any code references to this camera.
Camera Parameters for reference when adding back:
