Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Commit

Permalink
Fixed bug in experiment_from_huggingface.jsonnet (#238)
Browse files Browse the repository at this point in the history
* Fixed bug in `experiment_from_huggingface.jsonnet` by changing `min_count` to have key `labels` instead of `answers`

* Update CHANGELOG.md

Co-authored-by: Evan Pete Walsh <epwalsh10@gmail.com>

Co-authored-by: Arjun Subramonian <arjuns@ip-192-168-0-114.us-west-2.compute.internal>
Co-authored-by: Evan Pete Walsh <epwalsh10@gmail.com>
  • Loading branch information
3 people committed Mar 30, 2021
1 parent a8e0b00 commit abc7e19
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

### Fixed

- Fix bug in `experiment_from_huggingface.jsonnet` by changing `min_count` to have key `labels` instead of `answers`. Resolves failure of model checks that involve calling `_extend` in `vocabulary.py`


## [v2.2.0](https://github.com/allenai/allennlp-models/releases/tag/v2.2.0) - 2021-03-26

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ local model_name = "epwalsh/bert-xsmall-dummy";
},
"train_data_path": "test_fixtures/vision/visual_entailment/sample_pairs.jsonl",
"validation_data_path": "test_fixtures/vision/visual_entailment/sample_pairs.jsonl",
"vocabulary": {"min_count": {"answers": 2}},
"vocabulary": {"min_count": {"labels": 2}},
"datasets_for_vocab_creation": ["train"],
"model": {
"type": "ve_vilbert_from_huggingface",
Expand Down

0 comments on commit abc7e19

Please sign in to comment.