Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fixed bug in experiment_from_huggingface.jsonnet #238

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

ArjunSubramonian
Copy link
Contributor

Fixed bug in experiment_from_huggingface.jsonnet by changing min_count to have key labels instead of answers. Resolves failure of model checks that involve calling _extend in vocabulary.py (Related PR: allenai/allennlp#3644)

…ount` to have key `labels` instead of `answers`
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one thing with the CHANGELOG!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Evan Pete Walsh <epwalsh10@gmail.com>
@ArjunSubramonian ArjunSubramonian merged commit abc7e19 into main Mar 30, 2021
@ArjunSubramonian ArjunSubramonian deleted the arjuns/fix-min_count-bug branch March 30, 2021 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants