Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fixed bug in experiment_from_huggingface.jsonnet #238

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Fixed bug in experiment_from_huggingface.jsonnet #238

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0e2cd4
Fixed bug in `experiment_from_huggingface.jsonnet` by changing `min_c…
Mar 30, 2021
3f74df8
Update CHANGELOG.md
ArjunSubramonian Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

### Changed
ArjunSubramonian marked this conversation as resolved.
Show resolved Hide resolved

- Fix bug in `experiment_from_huggingface.jsonnet` by changing `min_count` to have key `labels` instead of `answers`. Resolves failure of model checks that involve calling `_extend` in `vocabulary.py`


## [v2.2.0](https://github.com/allenai/allennlp-models/releases/tag/v2.2.0) - 2021-03-26

Expand Down
2 changes: 1 addition & 1 deletion test_fixtures/vision/vilbert_ve/experiment_from_huggingface.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ local model_name = "epwalsh/bert-xsmall-dummy";
},
"train_data_path": "test_fixtures/vision/visual_entailment/sample_pairs.jsonl",
"validation_data_path": "test_fixtures/vision/visual_entailment/sample_pairs.jsonl",
"vocabulary": {"min_count": {"answers": 2}},
"vocabulary": {"min_count": {"labels": 2}},
"datasets_for_vocab_creation": ["train"],
"model": {
"type": "ve_vilbert_from_huggingface",
Expand Down