This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Add scalar_mix_parameters to ElmoTokenEmbedder #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
approved these changes
Oct 24, 2018
| scalar_mix_parameters : ``List[int]``, optional, (default=None) | ||
| If not ``None``, use these scalar mix parameters to weight the representations | ||
| produced by different layers. These mixing weights are not updated during | ||
| training. |
There was a problem hiding this comment.
Is there an option to just initialize to these values, but still train them? Just something to think about.
There was a problem hiding this comment.
yeah, you're right that this is currently missing. I didn't think anyone would use it / it would add extra complexity, so i just went with this for now.
There was a problem hiding this comment.
Yeah, definitely don't add it until there's a justification for it; I was just wondering about your experiments.
nelson-liu
added a commit
that referenced
this pull request
Oct 24, 2018
Sorry, continuation of #1955 . Was able to run a model with this setting, so pretty sure I got it right this time around...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.