Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

ensure parameters that are actual dictionaries get logged #4697

Merged
merged 2 commits into from
Oct 3, 2020
Merged

ensure parameters that are actual dictionaries get logged #4697

merged 2 commits into from
Oct 3, 2020

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Oct 2, 2020

No description provided.

matt-gardner
matt-gardner approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@matt-gardner matt-gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why we turned off logging for this; I don't see any reason to keep it off. We also are in the position of calling .as_dict() much less often now, I think. Just curious - where did you run into this?

@epwalsh
Copy link
Member Author

epwalsh commented Oct 3, 2020

I noticed when I was training a transformer model on SQuAD. The model took a dictionary of tokenizer_kwargs, but I noticed that wasn't showing in the logs.

@epwalsh epwalsh merged commit 3506e3f into master Oct 3, 2020
@epwalsh epwalsh deleted the from-params-fix branch October 3, 2020 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matt-gardner matt-gardner matt-gardner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epwalsh @matt-gardner