Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task 290 : TellMyWhy #168

Merged
merged 5 commits into from
Sep 4, 2021
Merged

Conversation

amirrezamirzaei
Copy link
Contributor

task 288 using TellMyWhy

@amirrezamirzaei amirrezamirzaei changed the title task 288 task 290 : TellMyWhy Sep 3, 2021
Copy link
Contributor

@yeganehkordi yeganehkordi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some suggestions:

  1. Please add the link to the dataset in the source field. TellMeWhy #143
  2. Why did He formulate a machine? Wasn't it because of that he decided to revolutionize the industry?
  3. Maybe you can mention in the description that question and passage are separated with "\n" or write the input with the format of {passage} \n Question: {question}

@amirrezamirzaei
Copy link
Contributor Author

@yeganehkordi thanks for the suggestions, I fixed them.

@yeganehkordi yeganehkordi mentioned this pull request Sep 3, 2021
@danyaljj
Copy link
Contributor

danyaljj commented Sep 4, 2021

Thanks!

For a future PRs: I think you can also create a task for answering why-questions that are answerable.

Copy link
Contributor

@swarooprm swarooprm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
+1 on creating more tasks from this dataset.

@swarooprm swarooprm merged commit 75e7116 into allenai:master Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants