Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default end date/time for events with no end time or duration #258

Merged
merged 8 commits into from
Dec 10, 2023
Merged

Add default end date/time for events with no end time or duration #258

merged 8 commits into from
Dec 10, 2023

Commits on Dec 10, 2023

  1. Add default end date/time for events with no end time or duration 

    Before this change, some events would be parsed and result in a
ValueError. According to RFC 5545 section 3.6.1, there are default
behaviors to be assumed in these cases - namely that events with a
starting date should assume the event is one full day, while events
with a starting time and date should assume zero duration.
    @dannycjones
    dannycjones committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    6b73f10 View commit details
    Browse the repository at this point in the history

  2. Simplify Event.computed_duration

    @dannycjones
    dannycjones committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    31f2975 View commit details
    Browse the repository at this point in the history

  3. Style fixes

    @dannycjones
    dannycjones committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    c8921d8 View commit details
    Browse the repository at this point in the history

  4. Add checks for duration and computed_duration in event

    @dannycjones
    dannycjones committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    1d432a6 View commit details
    Browse the repository at this point in the history

  5. Add calendar stream tests

    @dannycjones
    dannycjones committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    3af407d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix-event-no-dur-dtend

    @dannycjones
    dannycjones committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    30ca700 View commit details
    Browse the repository at this point in the history

  7. Remove guard for 'testdata/rrule-yearly.yaml' calendar stream test

    @dannycjones
    dannycjones committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    7049751 View commit details
    Browse the repository at this point in the history

  8. Revert "Add calendar stream tests" 

    This reverts commit 3af407d.
    @dannycjones
    dannycjones committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    bd4ac88 View commit details
    Browse the repository at this point in the history