Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw err instead of returning undefined in query fn #137

Merged
merged 5 commits into from
Feb 2, 2023
Merged

fix: throw err instead of returning undefined in query fn #137

merged 5 commits into from
Feb 2, 2023

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jan 31, 2023

Describe your changes

Throw error instead of returning undefined in query function

@bkioshn bkioshn added the bug Something isn't working label Jan 31, 2023
@vercel
Copy link

vercel bot commented Jan 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
celatone-demo-terra ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 3:57AM (UTC)
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 3:57AM (UTC)
terra-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 3:57AM (UTC)
3 Ignored Deployments
Name Status Preview Comments Updated
celatone-frontend-initial-demo ⬜️ Ignored (Inspect) Feb 2, 2023 at 3:57AM (UTC)
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Feb 2, 2023 at 3:57AM (UTC)
terra-celatone-frontend ⬜️ Ignored (Inspect) Feb 2, 2023 at 3:57AM (UTC)

evilpeach
evilpeach requested changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove eslint-ignore and add (functionName).

src/lib/services/codeService.ts Outdated Show resolved Hide resolved
songwongtp
songwongtp requested changes Jan 31, 2023
View reviewed changes
src/lib/services/codeService.ts Outdated Show resolved Hide resolved
@bkioshn bkioshn merged commit 0b514e0 into develop Feb 2, 2023
@bkioshn bkioshn deleted the fix/undefined-query-fn branch February 2, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@songwongtp songwongtp songwongtp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkioshn @evilpeach @songwongtp