Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove hardcode precision in attach funds #410

Merged
merged 14 commits into from
Jul 12, 2023
Merged

fix: remove hardcode precision in attach funds #410

merged 14 commits into from
Jul 12, 2023

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jun 29, 2023 •
edited
Loading

Describe your changes

  • Remove hardcode precision in attach funds dropdown selection.
  • Delete microfy and demicofy

@vercel
Copy link

vercel bot commented Jun 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beeb-celatone-frontend 🔄 Building (Inspect) Jul 12, 2023 4:33am
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 4:33am
terra-celatone-frontend 🔄 Building (Inspect) Jul 12, 2023 4:33am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
mitosis-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 12, 2023 4:33am
neutron-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 12, 2023 4:33am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Jul 12, 2023 4:33am
sei-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 12, 2023 4:33am
sei-mobile-celatone ⬜️ Ignored (Inspect) Jul 12, 2023 4:33am
sei-testnet-celatone-frontend ⬜️ Ignored (Inspect) Jul 12, 2023 4:33am
stargaze-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 12, 2023 4:33am
terra-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 12, 2023 4:33am

@bkioshn bkioshn requested a review from songwongtp June 29, 2023 05:01
songwongtp
songwongtp reviewed Jun 29, 2023
View reviewed changes
src/lib/utils/funds.ts Outdated Show resolved Hide resolved
@evilpeach evilpeach added the bug Something isn't working label Jun 29, 2023
poomthiti
poomthiti suggested changes Jun 30, 2023
View reviewed changes
src/lib/app-provider/hooks/useAttachFunds.ts Show resolved Hide resolved
src/lib/app-provider/hooks/useAttachFunds.ts Outdated Show resolved Hide resolved
src/lib/app-provider/hooks/useAttachFunds.ts Outdated Show resolved Hide resolved
src/lib/app-provider/hooks/useAttachFunds.ts Outdated Show resolved Hide resolved
src/lib/app-provider/hooks/useBaseApiRoute.ts Outdated Show resolved Hide resolved
@bkioshn bkioshn requested a review from poomthiti June 30, 2023 08:45
evilpeach
evilpeach requested changes Jun 30, 2023
View reviewed changes
src/lib/services/assetService.ts Outdated Show resolved Hide resolved
src/lib/services/assetService.ts Outdated Show resolved Hide resolved
src/lib/services/faucetService.ts Show resolved Hide resolved
src/lib/services/proposalService.ts Outdated Show resolved Hide resolved
@bkioshn bkioshn merged commit 38dde1f into develop Jul 12, 2023
6 checks passed
@bkioshn bkioshn deleted the fix/attach-fund-precision branch July 12, 2023 04:51
evilpeach pushed a commit that referenced this pull request Jul 12, 2023
@bkioshn @evilpeach
Merge pull request #410 from alleslabs/fix/attach-fund-precision
bfdf487 
fix: remove hardcode precision in attach funds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@songwongtp songwongtp songwongtp approved these changes

@poomthiti poomthiti poomthiti approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkioshn @evilpeach @songwongtp @poomthiti