Fix bug in travis config, update WP #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way that Travis was testing phpunit, only the result of qunit indicated that the job passed or failed
| @@ -39,7 +39,13 @@ script: | |||
| - | | |||
| if [[ ! -z "$WP_VERSION" ]] ; then | |||
| phpunit | |||
| fi | |||
| - | | |||
| if [[ ! -z "$WP_VERSION" ]] ; then | |||
There was a problem hiding this comment.
Is there is specific reason why the phpunit needs WP_VERSION, when it is not needed in other travis configs we use internally?
There was a problem hiding this comment.
The travis config that we use internally is a little different. This is really aimed at future improvements to FM's travis config.
|
Minor comment, otherwise ⛳ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that Travis was testing phpunit, only the result of qunit indicated that the job passed or failed