New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation to reflect the possibility of multiple display_if values... #619

Merged
merged 4 commits into from Oct 10, 2017

Conversation

3 participants
@kkoppenhaver
Contributor

kkoppenhaver commented Apr 28, 2017

...Clarifies #618

@kkoppenhaver

This comment has been minimized.

Show comment
Hide comment
@kkoppenhaver

kkoppenhaver Apr 28, 2017

Contributor

PHP 7 test looks to have failed because of config issues...

PHP Fatal error:  Class 'PHPUnit_Framework_TestCase' not found in /tmp/wordpress-tests-lib/includes/testcase.php on line 15
PHP Stack trace:
PHP   1. {main}() /home/travis/.phpenv/versions/7.0.17/bin/phpunit:0
PHP   2. PHPUnit\TextUI\Command::main() /home/travis/.phpenv/versions/7.0.17/bin/phpunit:468
PHP   3. PHPUnit\TextUI\Command->run() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/TextUI/Command.php:136
PHP   4. PHPUnit\TextUI\Command->handleArguments() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/TextUI/Command.php:147
PHP   5. PHPUnit\TextUI\Command->handleBootstrap() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/TextUI/Command.php:731
PHP   6. PHPUnit\Util\Fileloader::checkAndLoad() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/TextUI/Command.php:910
PHP   7. PHPUnit\Util\Fileloader::load() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/Util/Fileloader.php:39
PHP   8. include_once() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/Util/Fileloader.php:55
PHP   9. require() /home/travis/build/alleyinteractive/wordpress-fieldmanager/tests/php/bootstrap.php:26
PHP  10. require() /tmp/wordpress-tests-lib/includes/bootstrap.php:97

PHP 5.6 fails because of PHPCS warnings:

----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 230 | ERROR | Assignments must be the first block of code on a line
     |       | (Squiz.PHP.DisallowMultipleAssignments.Found)
 308 | ERROR | Assignments must be the first block of code on a line
     |       | (Squiz.PHP.DisallowMultipleAssignments.Found)
 308 | ERROR | get_page_by_path() is prohibited, please use
     |       | wpcom_vip_get_page_by_path() instead.
     |       | (WordPress.VIP.RestrictedFunctions.get_page_by_path_get_page_by_path)
 324 | ERROR | Assignments must be the first block of code on a line
     |       | (Squiz.PHP.DisallowMultipleAssignments.Found)
----------------------------------------------------------------------
Contributor

kkoppenhaver commented Apr 28, 2017

PHP 7 test looks to have failed because of config issues...

PHP Fatal error:  Class 'PHPUnit_Framework_TestCase' not found in /tmp/wordpress-tests-lib/includes/testcase.php on line 15
PHP Stack trace:
PHP   1. {main}() /home/travis/.phpenv/versions/7.0.17/bin/phpunit:0
PHP   2. PHPUnit\TextUI\Command::main() /home/travis/.phpenv/versions/7.0.17/bin/phpunit:468
PHP   3. PHPUnit\TextUI\Command->run() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/TextUI/Command.php:136
PHP   4. PHPUnit\TextUI\Command->handleArguments() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/TextUI/Command.php:147
PHP   5. PHPUnit\TextUI\Command->handleBootstrap() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/TextUI/Command.php:731
PHP   6. PHPUnit\Util\Fileloader::checkAndLoad() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/TextUI/Command.php:910
PHP   7. PHPUnit\Util\Fileloader::load() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/Util/Fileloader.php:39
PHP   8. include_once() phar:///home/travis/.phpenv/versions/7.0.17/bin/phpunit/phpunit/Util/Fileloader.php:55
PHP   9. require() /home/travis/build/alleyinteractive/wordpress-fieldmanager/tests/php/bootstrap.php:26
PHP  10. require() /tmp/wordpress-tests-lib/includes/bootstrap.php:97

PHP 5.6 fails because of PHPCS warnings:

----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 230 | ERROR | Assignments must be the first block of code on a line
     |       | (Squiz.PHP.DisallowMultipleAssignments.Found)
 308 | ERROR | Assignments must be the first block of code on a line
     |       | (Squiz.PHP.DisallowMultipleAssignments.Found)
 308 | ERROR | get_page_by_path() is prohibited, please use
     |       | wpcom_vip_get_page_by_path() instead.
     |       | (WordPress.VIP.RestrictedFunctions.get_page_by_path_get_page_by_path)
 324 | ERROR | Assignments must be the first block of code on a line
     |       | (Squiz.PHP.DisallowMultipleAssignments.Found)
----------------------------------------------------------------------
@dlh01

This comment has been minimized.

Show comment
Hide comment
@dlh01

dlh01 May 1, 2017

Member

@kkoppenhaver Your added documentation make sense to me. I opened #620 to address the Travis issues.

Member

dlh01 commented May 1, 2017

@kkoppenhaver Your added documentation make sense to me. I opened #620 to address the Travis issues.

@kkoppenhaver

This comment has been minimized.

Show comment
Hide comment
@kkoppenhaver

kkoppenhaver May 1, 2017

Contributor

@dlh01 Great! Following #620.

Contributor

kkoppenhaver commented May 1, 2017

@dlh01 Great! Following #620.

@kkoppenhaver

This comment has been minimized.

Show comment
Hide comment
@kkoppenhaver

kkoppenhaver May 1, 2017

Contributor

@dlh01 Do we need to re-run travis/is this something I can trigger?

Contributor

kkoppenhaver commented May 1, 2017

@dlh01 Do we need to re-run travis/is this something I can trigger?

@dlh01

This comment has been minimized.

Show comment
Hide comment
@dlh01

dlh01 May 1, 2017

Member

I think merging master into your branch will cause Travis to run again.

Member

dlh01 commented May 1, 2017

I think merging master into your branch will cause Travis to run again.

@kkoppenhaver

This comment has been minimized.

Show comment
Hide comment
@kkoppenhaver

kkoppenhaver May 1, 2017

Contributor

@dlh01 Travis fixes look good. Thanks for your help with those.

Contributor

kkoppenhaver commented May 1, 2017

@dlh01 Travis fixes look good. Thanks for your help with those.

@kkoppenhaver

This comment has been minimized.

Show comment
Hide comment
@kkoppenhaver

kkoppenhaver Jul 27, 2017

Contributor

@dlh01 Anything else you need from me on this?

Contributor

kkoppenhaver commented Jul 27, 2017

@dlh01 Anything else you need from me on this?

@dlh01

This comment has been minimized.

Show comment
Hide comment
@dlh01

dlh01 Aug 8, 2017

Member

I don't think so, thanks. This just needs a 👍 from an FM developer.

Member

dlh01 commented Aug 8, 2017

I don't think so, thanks. This just needs a 👍 from an FM developer.

@mboynes mboynes added this to the 1.2.0 milestone Oct 7, 2017

@mboynes mboynes added this to Backlog in 1.2.0 Oct 10, 2017

@mboynes mboynes self-assigned this Oct 10, 2017

@mboynes mboynes merged commit 736dc4f into alleyinteractive:master Oct 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mboynes

This comment has been minimized.

Show comment
Hide comment
@mboynes
Member

mboynes commented Oct 10, 2017

Thanks @kkoppenhaver!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment