This repository has been archived by the owner on May 1, 2024. It is now read-only.
Updates to head component #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomharrigan
reviewed
Oct 10, 2018
| return $meta_description; | ||
| } | ||
|
|
||
| // Modify global state. |
There was a problem hiding this comment.
The following should accomplish the same without modifying global state and having to set the temp variable apply_filters( 'get_the_excerpt', get_post_field( 'post_excerpt', $post_id ) )
There was a problem hiding this comment.
I had a long discussion with @mboynes about this and this was his recommended approach. He suggested avoiding the filter all together.
| public function get_social_image_url( $post_id, $photon_args = [] ) { | ||
|
|
||
| // Get image url. | ||
| $image_id = absint( get_post_meta( $post_id, 'social_image_id', true ) ); |
There was a problem hiding this comment.
might be good to return early if this isn't valid to avoid a wp_get_attachment_image_url call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional head tag updates