Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from using 'distutils' to 'setuptools' for installing AMBuild. #69

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

WildCard65
Copy link
Contributor

Fixes #68: See bpo-41282 for switch reason.

@dvander
Copy link
Member

dvander commented Jul 15, 2020

Thanks! I'll have to test this on our automated stuff, travis/appveyor install AMBuild from scratch each time, so there's potential for breakage. I should be able to do that soon.

@WildCard65
Copy link
Contributor Author

@dvander I have tested the changes locally with pip set to verbose mode, fundamentally, I believe nothing should break (find_packages() even found all packages that were initially manually provided)

@dvander
Copy link
Member

dvander commented Jul 16, 2020

Okay, let's just merge this then and we can revert or fix in place if it breaks infrastructure.

@dvander dvander merged commit 7178274 into alliedmodders:master Jul 16, 2020
@dvander
Copy link
Member

dvander commented Jul 16, 2020

This did break things, but it was simple enough to fix (the installation path of the "ambuild" script changed, I'm not sure what the new location is, but it's in PATH so I dropped the hardcoding).

@WildCard65
Copy link
Contributor Author

@dvander The "ambuild" script became an executable on Windows, and what ever setuptools determines to be appropriate for Mac/Linux systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch setup.py to use setuptools
2 participants