Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Adminslot: Trim spaces * Adminslot: Use semicolon everywhere * Adminslot: Use brackets everywhere * Adminslot: Hook cvars change and make sure max visible players is set right away * Adminslot: Rename g_sv_visiblemaxplayers * Adminslot: Move free slot calculation in its own function * Adminslot: Use create_cvar and define appropriate bounds * Adminslot: Use get_playersnum_ex with flag for clarity * Adminslot: Move all the logic inside setVisibleSlots Looks like the commit should have been split for clarity. The initial purpose is to avoid code duplication and regroup checks. The logic is the same with a little improvement to handle situations where a cvar is changed on-the-fly and sv_visiblemaxplayers needs to be reset. Ultimately, the logic is the following: - At player's connection: -- Do nothing if amx_reservation == 0 and sv_visiblemaxplayers <= 0. If sv_visiblemaxplayers is set, we reset it directly. -- Check if player needs to be kicked. If not, and amx_hideslots == 0, then do nothing. -- Otherwise we update sv_visiblemaxplayers - Others events: -- Do nothing if either amx_reservation == 0 or amx_hideslots == 0, and if sv_visiblemaxplayers <= 0. If sv_visiblemaxplayers is set, we reset it directly. -- Otherwise we update sv_visiblemaxplayers * Adminslot: Rename variables and adjust constantness * Adminslot: Add a description to the cvars * Adjust CVAR_HIDESLOTS english sentence * Add the Deutsch translations
- Loading branch information
Showing
2 changed files
with
75 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters