Bug with colored menus in Half-Life

[OciXCrom]

I got a report by a user that runs a Half-Life server that when he updated to AMXX 1.9 this happened with all the menus:

If I'm not mistaken, colored menus are not supported in Half-Life. It's probably a mistake made in PR #143. He has been using 1.8.2 before that and the menus worked fine without displaying the color symbols.

I tested as well to make sure - the color symbols appear in menus when using 1.9.0, downgrading to 1.8.2 removes them.

I also noticed another bug while testing the menus. If you leave a menu open and you leave the server, when you come back the menu stays open but you're not able to select anything from it. It happens even if you restart the server.

[Arkshine]

Then 'valve' should be removed from the list.
What about tfc and dmc?

[OciXCrom]

@Arkshine Yup, if it really doesn't support colored menus, better remove it ASAP because all HL menus are messed up at the moment.

I don't have those other games so I can't really test.

[Arkshine]

Tested with HL and TFC, and I see the color:

[WPMGPRoSToTeMa]

dmc supports them https://github.com/ValveSoftware/halflife/blob/5d761709a31ce1e71488f2668321de05f791b405/dmc/cl_dll/menu.cpp#L82-L125.
There is no support for colored menus in old hlsdk, so looks like it was added in 6xxx builds for half-life and similar games.

[OciXCrom]

I guess we need to check if the build version is 6xxx before adding these games in the list that supports colored menus.

[rsKliPPy]

AMXX only supports the latest build afaik, there's no need for such check.

[Arkshine]

We are not going to start to adjust stuff based on game build.
There is no reason to not update his server especially when the latest builds contains security fixes.

[WPMGPRoSToTeMa]

@Arkshine, client build is implied, but anyway AMX Mod X supports only the latest server/client engine build.

[Arkshine]

Yes, you're right.

[OciXCrom]

I see, the server that I tested on hasn't been updated for ages. This may be a problem who people that don't know how to update their server, but they will learn eventually.

PS: why did they have to hardcode the colors like that, RGB menus would have been much nicer. 😞

[Arkshine]

As stated WPMGPRoSToTeMa, this is a client-side feature, so the server is unrelated here.

[AoiKagase]

Left CS/Right Svencoop

It probably doesn't support the color specification of the number, but
It seems that the last color specification of the previous line remains until the next line.

I can change it back to white by specifying \w at the beginning of the menu, but you cannot specify it for the number part.

Is this a client-side bug?
(Svencoop team replied that the menu is implemented differently from other mods, including CS.)