Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SVC Messages #223

Merged
merged 2 commits into from Mar 12, 2015
Merged

Add missing SVC Messages #223

merged 2 commits into from Mar 12, 2015

Conversation

9iky6
Copy link
Contributor

@9iky6 9iky6 commented Mar 12, 2015

add svc messages id to use hardcode

add svc messages id to use hardcode (dont relize, only for alliedmodders dev team view)
@Arkshine
Copy link
Member

Thanks for contributing, but you do some wrong things.

  • Your title/commit message doesn't reflect the changes. Please take the time to write a proper message/title.
  • While adding missing SVC messages are welcomed, client events are not, because they are mod-dependent and you can't just write all, nor some won't have the same id. Also there a native for that. Please remove them.
  • You should avoid to insert random comments, especially when you mix english and some other language. Please remove it.
  • You still don't name properly your branch name. Right now it's called "pathc-14", can't you name it like "missing-svc-messages" or something? Now it's too late, but next time, please try to name your branch properly.

@Arkshine Arkshine changed the title Add_SVC_Messages Add missing SVC Messages Mar 12, 2015
@Arkshine
Copy link
Member

Looks ok, thanks.

Arkshine added a commit that referenced this pull request Mar 12, 2015
Add missing SVC Messages
@Arkshine Arkshine merged commit f83e7f0 into alliedmodders:master Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants