Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing SQL_SetCharset native in SQLite #236

Merged
merged 1 commit into from Apr 20, 2015
Merged

Fix missing SQL_SetCharset native in SQLite #236

merged 1 commit into from Apr 20, 2015

Conversation

Arkshine
Copy link
Member

Even though SQLite doesn't need this, It's motivated by the following:

  • For consistency, considering SQLite and MySQL use the same API, it should be there
  • For usability, when your plugin deals with both driver dynamically, you would want to have the same code for both (meaning not checking driver name to use native)

@xPaw
Copy link
Contributor

xPaw commented Apr 12, 2015

Documentation for SQL_SetCharset should have a note saying that this native does nothing in sqlite.

@Arkshine
Copy link
Member Author

Done.

@Nextra
Copy link
Contributor

Nextra commented Apr 20, 2015

lgtm

Arkshine added a commit that referenced this pull request Apr 20, 2015
@Arkshine
Merge pull request #236 from Arkshine/fix/missing-sqlite-charset
cc11191 
Fix missing SQL_SetCharset native in SQLite
@Arkshine Arkshine merged commit cc11191 into alliedmodders:master Apr 20, 2015
@Arkshine Arkshine deleted the fix/missing-sqlite-charset branch April 20, 2015 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug module: sqlite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Arkshine @xPaw @Nextra