Fix player not being internally disconnected in some situation and add client_disconnected forward #264
Conversation
Arkshine
force-pushed
the
fix/dropclient
branch
2 times, most recently
from
f02f013
to
3494d49
Compare
|
|
||
| DETOUR_STATIC_CALL(SV_DropClient)(cl, crash, "%s", buffer); | ||
|
|
||
| pPlayer->Disconnect(); |
There was a problem hiding this comment.
This should be inside if (cl->edict)
Arkshine
force-pushed
the
fix/dropclient
branch
4 times, most recently
from
d5ec961
to
f39e08d
Compare
Arkshine
changed the title
|
So, after some discussions, it would be more appropriate/convenient/usable to have a replacement instead. There we go, a new forward |
|
Have the commits take into account FM_ClientDisconnect forward from fakemeta? Also, why client_disconnect is called when player disconnects or map change (1 called for each player connected) and FM_ClientDisconnect only called when player disconnects? I'm talking about FM_ClientDisconnect in Pre |
|
I'm not sure why you're talking about |
|
You said: "...some unexpected result, also client_disconnect won't be called." Also, I asked other thing, but any problem if no answer, it was only curiosity. |
|
If you follow #252 this is a situation where
|
|
Looks fine to me now. |
| } | ||
| else | ||
| { | ||
| AMXXLOG_Log("client_drop forward has been disabled - check your gamedata files."); |
There was a problem hiding this comment.
fwd name and description are wrong, the forward is not fully disabled
Arkshine
force-pushed
the
fix/dropclient
branch
2 times, most recently
from
dab4daa
to
15ad5bc
Compare
|
🚢 |
Arkshine
force-pushed
the
fix/dropclient
branch
2 times, most recently
from
e3a0d0a
to
ed4faf7
Compare
…client_disconnected forward
Fix player not being internally disconnected in some situation and add client_disconnected forward
Introduced in alliedmodders#264. Edict is reset once SV_DropClient is called, so that second check would be always false.
…disconnected (#414) * Rename client_disconnected to client_disconnecting * Add client_disconnected as post forward * Fix client not properly disconnected internally Introduced in #264. Edict is reset once SV_DropClient is called, so that second check would be always false. * Reflect changes on the concerned plugins * Revert renaming, let's add only client_remove as post forward
Issue reported by @WPMGPRoSToTeMa here #252.
This fixes the situation of a player is marked as initialized by AMXX but has not yet spawned (put in server), if he disconnects/crashes/timeout at this point,
pfnClientDisconnectwon't be triggered by the engine. Result: AMXX will think that this player is still initialized and as consequence code relying on it could provide some unexpected result, alsoclient_disconnectwon't be called.While it's necessary that this change be reflected on
client_disconnect, instead for backward compatibility reason a new forwardclient_disconnectedhas been introduced to be used as replacement.client_disconnectis marked as deprecated.Technical note: Core hooks
SV_DropClient, reHLDS could be supported later, once release is considerate as stable, and/or there is a more friendly approach of the API.