Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signed/unsigned mismatch warning #428

Merged
merged 2 commits into from
Apr 4, 2017
Merged

Fix signed/unsigned mismatch warning #428

merged 2 commits into from
Apr 4, 2017

Conversation

IgnacioFDM
Copy link
Contributor

No description provided.

@Amaroq7
Copy link
Contributor

Amaroq7 commented Apr 3, 2017

These kind of warnings also occur in:

It'd be great if you could fix them all at once.

@IgnacioFDM
Copy link
Contributor Author

Weird, is that with GCC? Because I don't get them with VC++

@Amaroq7
Copy link
Contributor

Amaroq7 commented Apr 3, 2017

Yes, GCC version 6.3.1

@IgnacioFDM
Copy link
Contributor Author

Haven't compiled with GCC and I'm not sure if these fixes would be "correct", so please review the changes

@IgnacioFDM
Copy link
Contributor Author

(forgot the file.cpp one)

@Amaroq7
Copy link
Contributor

Amaroq7 commented Apr 3, 2017

Compiles without warnings 👍

Arkshine
Arkshine approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@Arkshine Arkshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Arkshine Arkshine merged commit 2d049b7 into alliedmodders:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkshine Arkshine Arkshine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IgnacioFDM @Amaroq7 @Arkshine