Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADMIN_SUPER flag #480

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

OciXCrom
Copy link
Contributor

Users with flag "x" (ADMIN_SUPER) are able to bypass the ADMIN_IMMUNITY flag on commands that are properly made with cmd_target.

@rsKliPPy
Copy link
Contributor

rsKliPPy commented Feb 10, 2018

All plugins have to be recompiled to make this applicable. If cmd_target was a native, and it sadly isn't, it would've been fine. I'd say this is a problem, because some commands will ignore immunity and some won't.
I like the change, but we really need more opinions on this one.

@OciXCrom
Copy link
Contributor Author

I don't think that's really a problem. It's probably safer to compile them after updating anyways. Still, compiling all plugins takes only a few seconds, so that shouldn't stop us from introducing a new feature.

@OciXCrom OciXCrom changed the title Added ADMIN_SUPER flag Add ADMIN_SUPER flag Jul 29, 2018
@OciXCrom
Copy link
Contributor Author

OciXCrom commented Nov 24, 2019

@afwn90cj93201nixr2e1re That's extremely unlikely. Even if it does happen, it's even more unlikely that it will break anything that badly. Plus, these are default unused AMXX flags, so we might as well do something with them.

A similar change was already made with the new "v" flag for tempban, so there's no point in backing out now for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants