Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send pre-formatted string in SayText and TextMSg as a parameter instead of as the format string #763

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@Arkshine
Copy link
Member

Arkshine commented Oct 13, 2019

Related to ValveSoftware/halflife#2611.

This a compatibility update now the HL stable version has been updated.
This change should be safe.

Fixes #762.

…ad of as the format string
@Arkshine Arkshine added the core label Oct 13, 2019
@basuritashka

This comment has been minimized.

Copy link

basuritashka commented Oct 13, 2019

Thanks!

@FEDERICOMB96

This comment has been minimized.

Copy link

FEDERICOMB96 commented Oct 13, 2019

Thanks ! 😃

@Arkshine Arkshine merged commit 8309a1e into alliedmodders:master Oct 17, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Arkshine Arkshine deleted the Arkshine:fix/saytext-txtmsg branch Oct 17, 2019
Arkshine added a commit that referenced this pull request Oct 17, 2019
Arkshine added a commit that referenced this pull request Oct 23, 2019
Arkshine added a commit that referenced this pull request Oct 23, 2019
Arkshine added a commit that referenced this pull request Oct 27, 2019
* Fix newlines for TextMsg

* Fix newlines for SayText

* Adjust comments

* Replace hardcoded detination value with HUD_* constants

* Make sure only official mods can use format string

* Fix typos

* Split condition for readability

* CS only: Fix newlines in TextMsg and with print_center
Arkshine added a commit that referenced this pull request Oct 27, 2019
* Fix newlines for TextMsg

* Fix newlines for SayText

* Adjust comments

* Replace hardcoded detination value with HUD_* constants

* Make sure only official mods can use format string

* Fix typos

* Split condition for readability

* CS only: Fix newlines in TextMsg and with print_center
@Arkshine Arkshine mentioned this pull request Nov 14, 2019
@voed

This comment has been minimized.

Copy link
Contributor

voed commented Nov 18, 2019

@Arkshine

void UTIL_TextMsg_Generic(edict_t* pPlayer, const char* message)
should be fixed too(or just removed, it used just twice in code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.