Send pre-formatted string in SayText and TextMSg as a parameter instead of as the format string #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of as the format string
|
Thanks! |
|
Thanks ! 😃 |
Arkshine
added a commit
that referenced
this pull request
Oct 17, 2019
…ad of as the format string (#763)
This was referenced Oct 26, 2019
Arkshine
added a commit
that referenced
this pull request
Oct 27, 2019
* Fix newlines for TextMsg * Fix newlines for SayText * Adjust comments * Replace hardcoded detination value with HUD_* constants * Make sure only official mods can use format string * Fix typos * Split condition for readability * CS only: Fix newlines in TextMsg and with print_center
Arkshine
added a commit
that referenced
this pull request
Oct 27, 2019
* Fix newlines for TextMsg * Fix newlines for SayText * Adjust comments * Replace hardcoded detination value with HUD_* constants * Make sure only official mods can use format string * Fix typos * Split condition for readability * CS only: Fix newlines in TextMsg and with print_center
| should be fixed too(or just removed, it used just twice in code) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ValveSoftware/halflife#2611.
This a compatibility update now the HL stable version has been updated.
This change should be safe.
Fixes #762.