Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSVC 1912 support #761

Closed
WildCard65 opened this issue Jan 28, 2018 · 0 comments · Fixed by #764
Closed

Add MSVC 1912 support #761

WildCard65 opened this issue Jan 28, 2018 · 0 comments · Fixed by #764

Comments

@WildCard65
Copy link
Contributor

WildCard65 commented Jan 28, 2018 •
edited
Loading

Visual Studio 2017 version 15.5 added more support for more C++ 17 features, this caused MSVC's version to be bumped up to version 1912 (from previous version 1911).

I forgot PR #678 existed which is why it wasn't notified about the required change to support this new version.
@Headline Headline mentioned this issue Feb 4, 2018
Merged
psychonic pushed a commit that referenced this issue Feb 4, 2018
@Headline @psychonic
Add support for msvc 1912 (Fixes #761) (#764)
e57dce7 
* Add support for msvc 1912

* Default new msvc versions to VS 2017

* Use 2015 lib with 2017
sneak-it pushed a commit to sneak-it/sourcemod that referenced this issue Sep 22, 2018
@Headline @sneak-it
Add support for msvc 1912 (Fixes alliedmodders#761) (alliedmodders#764)
33c75d1 
* Add support for msvc 1912

* Default new msvc versions to VS 2017

* Use 2015 lib with 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use msvc 2015 lib with 2017 (#764)
1 participant
@WildCard65