Event.FireToClient fixups #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handle does not get mutated here, so it is safe. Since we don't currently support cloning event handles or copying events, this also facilitates the only easy way of firing an existing game- created event to a client.
Event.FireToClient should not care whether or not broadcasting is enabled for the event since we're already intentionally not broadcasting.
|
🚢 |
|
Funny thing is, dontbroadcast bugged me on the previous PR #505. |
|
@Benoist3012 Yes, that was the original intent. The example code in that PR showed it working, when it really didn't. I had either missed that case in my testing, or tested before adding the handle ownership check. |
|
Line 135 in 0aa1137 |
|
@KyleSanderson I think we want to keep that check since the handle gets freed at the end of that path. |
asherkin
approved these changes
Jan 3, 2017
|
This should land in 1.8 too! |
|
What all is left holding us up from just making 1.9 the stable branch?
…Sent from my iPhone
On Feb 18, 2017, at 5:26 PM, peace-maker ***@***.***> wrote:
This should land in 1.8 too!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a couple of checks that are IMO unnecessary. See commit messages for details and reasoning.