Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection of plugin cleanups #777

Merged
merged 6 commits into from Jul 12, 2018

Conversation

@KyleSanderson
Copy link
Member

KyleSanderson commented Mar 3, 2018

Just doing drive-bys on first-party plugins.

@@ -86,7 +86,7 @@ public void OnPluginStart()
}
}

public void OnMapStart()
public void OnConfigsExecuted()

This comment has been minimized.

Copy link
@asherkin

asherkin Mar 3, 2018

Member

LoadBanReasons doesn't rely on anything from a config file, OnMapStart is a better choice.

This comment has been minimized.

Copy link
@KyleSanderson

KyleSanderson Jul 12, 2018

Author Member

g_BanReasonsPath is a config file :-)


if(g_Voted[client])
if (g_Voted[client])

This comment has been minimized.

Copy link
@asherkin

asherkin Mar 3, 2018

Member

This will never be hit now.

This comment has been minimized.

Copy link
@KyleSanderson

KyleSanderson Mar 3, 2018

Author Member

Great catch, thanks

@KyleSanderson KyleSanderson merged commit d0bf261 into master Jul 12, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@KyleSanderson KyleSanderson deleted the thepawnining branch Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.