-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collection of plugin cleanups #777
Conversation
@@ -86,7 +86,7 @@ public void OnPluginStart() | |||
} | |||
} | |||
|
|||
public void OnMapStart() | |||
public void OnConfigsExecuted() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LoadBanReasons
doesn't rely on anything from a config file, OnMapStart
is a better choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g_BanReasonsPath is a config file :-)
plugins/rockthevote.sp
Outdated
|
||
if(g_Voted[client]) | ||
if (g_Voted[client]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will never be hit now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks
Just doing drive-bys on first-party plugins.