Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Switch CS:GO Clantag set/get to use netprops + offset over sig + offset. #922
I'm not too worked up about any of this (I don't like the style of the existing code now that was shuffled; but that's okay).
My preference would be for 1.9 to preserve the gamedata method and 1.10 we move onwards and forwards with this. If it breaks irrevocably we'll backport or pin 1.10.
psychonic left a comment
Looks good to me.
@Headline I think there's some benefit to keeping consistency with existing code surrounding the rest, at least enough that it doesn't need to be a priority to change. We could still do that in large passes though if we deem necessary. If this were a new extension or a total revamp of one, it'd be different.