Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just process some modules #12

Closed
abgit opened this issue Aug 8, 2013 · 3 comments
Closed

just process some modules #12

abgit opened this issue Aug 8, 2013 · 3 comments
Assignees
@allinurl
Labels
enhancement

Comments

@abgit
Copy link
Contributor

abgit commented Aug 8, 2013

On big logs, when we have millions of hosts, we get a very very big export with lots of info. And sometimes that aditional info is not necessary.

I propose to have a way to select modules to process.
So, we can choose if we want to process "hosts", "referer", "404" or other modules. This way we can define modules to process (or as an alternative modules do exclude).

Something like:

# goaccess  -p general,unique,requested -f access.log

so, in previous example, goaccess will only process and give information about general stats, unique visits per day and requested pages only.

What do you think?
@allinurl
Copy link
Owner

allinurl commented Aug 9, 2013

I'm assuming this would be to reduce parsing time? I can implement it but it would probably be only when outputting to STDOUT.

@abgit
Copy link
Contributor Author

abgit commented Aug 9, 2013

goal is to reduce parsing time and reduce output html content (imagine someone don't need hosts list, why get thousands of lines if not needed?).

@ghost ghost assigned allinurl Aug 28, 2013
@allinurl allinurl mentioned this issue Nov 11, 2013
Closed
@allinurl
Copy link
Owner

This has been implemented in v0.9. Thanks.

@TempleNode TempleNode mentioned this issue Sep 9, 2015
Closed
cgzones added a commit to cgzones/goaccess that referenced this issue Sep 10, 2021
@cgzones
Avoid buffer underflow
7ac10de 
Check if requested string is long enough for comparison.

    ==65303==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000013a4d at pc 0x00000043e1cb bp 0x7ffe4e3c09a0 sp 0x7ffe4e3c0140
    READ of size 1 at 0x602000013a4d thread T0
        #0 0x43e1ca in __interceptor_strncasecmp (/home/christian/Coding/workspaces/goaccess/goaccess+0x43e1ca)
        allinurl#1 0x5922e0 in verify_static_content /home/christian/Coding/workspaces/goaccess/src/parser.c
        allinurl#2 0x5922e0 in is_static /home/christian/Coding/workspaces/goaccess/src/parser.c:1487:10
        allinurl#3 0x58ecbc in pre_process_log /home/christian/Coding/workspaces/goaccess/src/parser.c:1775:12
        allinurl#4 0x593bd5 in read_line /home/christian/Coding/workspaces/goaccess/src/parser.c:1797:14
        allinurl#5 0x593bd5 in read_lines /home/christian/Coding/workspaces/goaccess/src/parser.c:1914:16
        allinurl#6 0x593bd5 in read_log /home/christian/Coding/workspaces/goaccess/src/parser.c:2008:7
        allinurl#7 0x593bd5 in parse_log /home/christian/Coding/workspaces/goaccess/src/parser.c:2059:9
        allinurl#8 0x55c83a in main /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1612:14
        allinurl#9 0x7f00dae96e49 in __libc_start_main csu/../csu/libc-start.c:314:16
        allinurl#10 0x4289d9 in _start (/home/christian/Coding/workspaces/goaccess/goaccess+0x4289d9)

    0x602000013a4d is located 3 bytes to the left of 3-byte region [0x602000013a50,0x602000013a53)
    allocated by thread T0 here:
        #0 0x4a519d in malloc (/home/christian/Coding/workspaces/goaccess/goaccess+0x4a519d)
        allinurl#1 0x61d38a in xmalloc /home/christian/Coding/workspaces/goaccess/src/xmalloc.c:46:14
        allinurl#2 0x61d569 in xstrdup /home/christian/Coding/workspaces/goaccess/src/xmalloc.c:58:9
        allinurl#3 0x59b1ac in decode_url /home/christian/Coding/workspaces/goaccess/src/parser.c:325:19
        allinurl#4 0x59b6a3 in parse_req /home/christian/Coding/workspaces/goaccess/src/parser.c:559:16
        allinurl#5 0x5978df in parse_specifier /home/christian/Coding/workspaces/goaccess/src/parser.c:1026:20
        allinurl#6 0x5904aa in parse_format /home/christian/Coding/workspaces/goaccess/src/parser.c:1382:18
        allinurl#7 0x58dc07 in pre_process_log /home/christian/Coding/workspaces/goaccess/src/parser.c:1743:11
        allinurl#8 0x593bd5 in read_line /home/christian/Coding/workspaces/goaccess/src/parser.c:1797:14
        allinurl#9 0x593bd5 in read_lines /home/christian/Coding/workspaces/goaccess/src/parser.c:1914:16
        allinurl#10 0x593bd5 in read_log /home/christian/Coding/workspaces/goaccess/src/parser.c:2008:7
        allinurl#11 0x593bd5 in parse_log /home/christian/Coding/workspaces/goaccess/src/parser.c:2059:9
        allinurl#12 0x55c83a in main /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1612:14
        allinurl#13 0x7f00dae96e49 in __libc_start_main csu/../csu/libc-start.c:314:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allinurl allinurl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@allinurl @abgit