Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for horizontal scrolling, long paths cut off #4

Open
maxandersen opened this issue Jul 31, 2013 · 5 comments
Open

Add option for horizontal scrolling, long paths cut off #4

maxandersen opened this issue Jul 31, 2013 · 5 comments
Assignees
@allinurl
Labels
enhancement terminal output

Comments

@maxandersen
Copy link

we got logs where the path exceeds the console screen width meaning the path gets cut off and ... put instead.

I was hoping the html version would not do that but it does.

Couldn't find a way to scroll nor set the width to some larger value.
@allinurl
Copy link
Owner

Hello, thanks for the heads up on this. I can certainly add a horizontal scroll to the to-do list. As far as the html version, I'll add the ability to set the width of the table in the upcoming version.

@maxandersen
Copy link
Author

cool :)

@ghost ghost assigned allinurl Aug 7, 2013
@Brade
Copy link

Brade commented Aug 27, 2015

Is this available now? Love the tool, but can barely see what any of my full URL's are.

@allinurl
Copy link
Owner

It is not available yet, but thanks for reminding me, I'll bump this up on the to-do list. Stay tuned ;)

@Brade
Copy link

Brade commented Aug 27, 2015

great!

@TempleNode TempleNode mentioned this issue Sep 9, 2015
Closed
@allinurl allinurl changed the title long paths cut off, add option for width or provide horizontal scrolling Add option for horizontal scrolling, long paths cut off Oct 4, 2015
cgzones added a commit to cgzones/goaccess that referenced this issue Jun 20, 2020
@cgzones
Rework sigsev handler
8573842 
Do not exit immediately, instead call previously set sigsev handler,
which might be a handler provided by a third party tool like ASAN.

Example extended crash output:

==23351== GoAccess 1.4 crashed by Sig 11
==23351==
==23351== VALUES AT CRASH POINT
==23351==
==23351== Line number: 10000
==23351== Offset: 10000
==23351== Invalid data: 0
==23351== Piping: 0
==23351==
==23351== STACK TRACE:
==23351==
==23351== 0 ./goaccess(backtrace+0x5b) [0x45d88b]
==23351== 1 ./goaccess(sigsegv_handler+0x14a) [0x4d9dca]
==23351== 2 /lib/x86_64-linux-gnu/libpthread.so.0(+0x14110) [0x7f4ed7e4c110]
==23351== 3 ./goaccess(parse_raw_data+0x5d) [0x50bd3d]
==23351== 4 ./goaccess() [0x54c896]
==23351== 5 ./goaccess() [0x552d3f]
==23351== 6 ./goaccess() [0x550bb5]
==23351== 7 ./goaccess() [0x54fc26]
==23351== 8 ./goaccess() [0x54a9d1]
==23351== 9 ./goaccess(main+0x2b4) [0x549c74]
==23351== 10 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7f4ed7b2ae0b]
==23351== 11 ./goaccess(_start+0x2a) [0x42686a]
==23351==
==23351== Please report it by opening an issue on GitHub:
==23351== https://github.com/allinurl/goaccess/issues

AddressSanitizer:DEADLYSIGNAL
=================================================================
==23351==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000010 (pc 0x00000050bd3d bp 0x7ffef6429050 sp 0x7ffef6429030 T0)
==23351==The signal is caused by a READ memory access.
==23351==Hint: address points to the zero page.
    #0 0x50bd3d in parse_raw_data /home/christian/Coding/workspaces/goaccess/src/gkhash.c:3097:44
    allinurl#1 0x54c895 in allocate_holder_by_module /home/christian/Coding/workspaces/goaccess/src/goaccess.c:303:14
    allinurl#2 0x552d3e in expand_module_from_ypos /home/christian/Coding/workspaces/goaccess/src/goaccess.c:524:3
    allinurl#3 0x550bb4 in expand_on_mouse_click /home/christian/Coding/workspaces/goaccess/src/goaccess.c:541:5
    allinurl#4 0x54fc25 in get_keys /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1060:7
    allinurl#5 0x54a9d0 in curses_output /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1171:3
    allinurl#6 0x549c73 in main /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1469:5
    allinurl#7 0x7f4ed7b2ae0a in __libc_start_main csu/../csu/libc-start.c:308:16
    allinurl#8 0x426869 in _start (/home/christian/Coding/workspaces/goaccess/goaccess+0x426869)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/christian/Coding/workspaces/goaccess/src/gkhash.c:3097:44 in parse_raw_data
==23351==ABORTING
cgzones added a commit to cgzones/goaccess that referenced this issue Jun 23, 2020
@cgzones
Rework sigsegv handler
dc3e2a1 
Do not exit immediately, instead call previously set sigsegv handler,
which might be a handler provided by a third party tool like ASAN.

Example extended crash output:

==23351== GoAccess 1.4 crashed by Sig 11
==23351==
==23351== VALUES AT CRASH POINT
==23351==
==23351== Line number: 10000
==23351== Offset: 10000
==23351== Invalid data: 0
==23351== Piping: 0
==23351==
==23351== STACK TRACE:
==23351==
==23351== 0 ./goaccess(backtrace+0x5b) [0x45d88b]
==23351== 1 ./goaccess(sigsegv_handler+0x14a) [0x4d9dca]
==23351== 2 /lib/x86_64-linux-gnu/libpthread.so.0(+0x14110) [0x7f4ed7e4c110]
==23351== 3 ./goaccess(parse_raw_data+0x5d) [0x50bd3d]
==23351== 4 ./goaccess() [0x54c896]
==23351== 5 ./goaccess() [0x552d3f]
==23351== 6 ./goaccess() [0x550bb5]
==23351== 7 ./goaccess() [0x54fc26]
==23351== 8 ./goaccess() [0x54a9d1]
==23351== 9 ./goaccess(main+0x2b4) [0x549c74]
==23351== 10 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7f4ed7b2ae0b]
==23351== 11 ./goaccess(_start+0x2a) [0x42686a]
==23351==
==23351== Please report it by opening an issue on GitHub:
==23351== https://github.com/allinurl/goaccess/issues

AddressSanitizer:DEADLYSIGNAL
=================================================================
==23351==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000010 (pc 0x00000050bd3d bp 0x7ffef6429050 sp 0x7ffef6429030 T0)
==23351==The signal is caused by a READ memory access.
==23351==Hint: address points to the zero page.
    #0 0x50bd3d in parse_raw_data /home/christian/Coding/workspaces/goaccess/src/gkhash.c:3097:44
    allinurl#1 0x54c895 in allocate_holder_by_module /home/christian/Coding/workspaces/goaccess/src/goaccess.c:303:14
    allinurl#2 0x552d3e in expand_module_from_ypos /home/christian/Coding/workspaces/goaccess/src/goaccess.c:524:3
    allinurl#3 0x550bb4 in expand_on_mouse_click /home/christian/Coding/workspaces/goaccess/src/goaccess.c:541:5
    allinurl#4 0x54fc25 in get_keys /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1060:7
    allinurl#5 0x54a9d0 in curses_output /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1171:3
    allinurl#6 0x549c73 in main /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1469:5
    allinurl#7 0x7f4ed7b2ae0a in __libc_start_main csu/../csu/libc-start.c:308:16
    allinurl#8 0x426869 in _start (/home/christian/Coding/workspaces/goaccess/goaccess+0x426869)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/christian/Coding/workspaces/goaccess/src/gkhash.c:3097:44 in parse_raw_data
==23351==ABORTING
cgzones added a commit to cgzones/goaccess that referenced this issue Sep 10, 2021
@cgzones
Avoid buffer underflow
7ac10de 
Check if requested string is long enough for comparison.

    ==65303==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000013a4d at pc 0x00000043e1cb bp 0x7ffe4e3c09a0 sp 0x7ffe4e3c0140
    READ of size 1 at 0x602000013a4d thread T0
        #0 0x43e1ca in __interceptor_strncasecmp (/home/christian/Coding/workspaces/goaccess/goaccess+0x43e1ca)
        allinurl#1 0x5922e0 in verify_static_content /home/christian/Coding/workspaces/goaccess/src/parser.c
        allinurl#2 0x5922e0 in is_static /home/christian/Coding/workspaces/goaccess/src/parser.c:1487:10
        allinurl#3 0x58ecbc in pre_process_log /home/christian/Coding/workspaces/goaccess/src/parser.c:1775:12
        allinurl#4 0x593bd5 in read_line /home/christian/Coding/workspaces/goaccess/src/parser.c:1797:14
        allinurl#5 0x593bd5 in read_lines /home/christian/Coding/workspaces/goaccess/src/parser.c:1914:16
        allinurl#6 0x593bd5 in read_log /home/christian/Coding/workspaces/goaccess/src/parser.c:2008:7
        allinurl#7 0x593bd5 in parse_log /home/christian/Coding/workspaces/goaccess/src/parser.c:2059:9
        allinurl#8 0x55c83a in main /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1612:14
        allinurl#9 0x7f00dae96e49 in __libc_start_main csu/../csu/libc-start.c:314:16
        allinurl#10 0x4289d9 in _start (/home/christian/Coding/workspaces/goaccess/goaccess+0x4289d9)

    0x602000013a4d is located 3 bytes to the left of 3-byte region [0x602000013a50,0x602000013a53)
    allocated by thread T0 here:
        #0 0x4a519d in malloc (/home/christian/Coding/workspaces/goaccess/goaccess+0x4a519d)
        allinurl#1 0x61d38a in xmalloc /home/christian/Coding/workspaces/goaccess/src/xmalloc.c:46:14
        allinurl#2 0x61d569 in xstrdup /home/christian/Coding/workspaces/goaccess/src/xmalloc.c:58:9
        allinurl#3 0x59b1ac in decode_url /home/christian/Coding/workspaces/goaccess/src/parser.c:325:19
        allinurl#4 0x59b6a3 in parse_req /home/christian/Coding/workspaces/goaccess/src/parser.c:559:16
        allinurl#5 0x5978df in parse_specifier /home/christian/Coding/workspaces/goaccess/src/parser.c:1026:20
        allinurl#6 0x5904aa in parse_format /home/christian/Coding/workspaces/goaccess/src/parser.c:1382:18
        allinurl#7 0x58dc07 in pre_process_log /home/christian/Coding/workspaces/goaccess/src/parser.c:1743:11
        allinurl#8 0x593bd5 in read_line /home/christian/Coding/workspaces/goaccess/src/parser.c:1797:14
        allinurl#9 0x593bd5 in read_lines /home/christian/Coding/workspaces/goaccess/src/parser.c:1914:16
        allinurl#10 0x593bd5 in read_log /home/christian/Coding/workspaces/goaccess/src/parser.c:2008:7
        allinurl#11 0x593bd5 in parse_log /home/christian/Coding/workspaces/goaccess/src/parser.c:2059:9
        allinurl#12 0x55c83a in main /home/christian/Coding/workspaces/goaccess/src/goaccess.c:1612:14
        allinurl#13 0x7f00dae96e49 in __libc_start_main csu/../csu/libc-start.c:314:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allinurl allinurl

Labels
enhancement terminal output
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Brade @maxandersen @allinurl