-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict protocol parsing #30
Comments
Thanks for posting this. Could you please explain a bit more what do you mean with Thanks |
Sure, |
Thank you for expanding on this issue. I'm happy to merge this. However, just to be sure, would you be able to run this on a non-arduino machine and see if this change still produces the right output? Let me know. |
I have tested gwsocket on Fedora-x64 as well as Lede(OpenWRT)-mips_24kc. As a remote point for strict protocol I have used Arduino and I also tested with pipe-in/pipe-out commands simulation on a local machine. |
Hi @allinurl, |
@itsanov Thanks for the reminder. Yes, please feel free to submit a PR and I'm happy to take a look and merge it upstream. |
Closing this as it appears it has been addressed in #33. Feel free to reopen it if needed |
Hi,
First and most important: Nice work! Thank you!
I'm trying to connect Arduino with web browser with "gwsocket". Communication is binary.
gwsocket --strict --pipein=/dev/ttyS1 --pipeout=/dev/ttyS1 --max-frame-size=128
Unfortunately, when Arduino is restarted gwsocket strict protocol parser gets out of sync and can't return back.
I have implemented a workaround. Please have a look.
websocket.c:2687
Current implementation is throwing away the complete header (12 bytes) when header is not OK. My change is to throw away just one byte and to try again.
Cheers
The text was updated successfully, but these errors were encountered: