Rails5 #63
Open
Rails5 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's holding back the merge, aside from a quick rebase? |
leeomara
reviewed
Apr 30, 2019
| @@ -0,0 +1,4 @@ | |||
| FACEBOOK_API_KEY: 830527976957438 | |||
There was a problem hiding this comment.
I expect that API keys and secrets should not be included as part of this pull request.
There was a problem hiding this comment.
Development is stopped. I already noticed above all parts are not ported. Please finish it by yourself or by another enthusiast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Most parts are ported and tests should pass. Photocracy is not ported.
Gem activeresource has minor changes - POST means create new record, PUT means update existing record. This lead to single line changes in the pairwise api routes (post to put).
Front-end is not touched, files moved only. Right now I am not sure highcharts works correct.