You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
alloy itself exposes recover_signer yet not a 1:1 implementation of ecrecover.
ethers-rs did expose a recover function, internally calling the ecdsa crate.
ecdsa doesn't explicitly implement ecrecover, as defined in Ethereum. Please note their policy on low/high s values: RustCrypto/elliptic-curves#991
This did break an EVM dependent on it (which bubbled up into foundry IIRC).
While I could implement ecrecover myself based on ecdsa, I do not want to have to review the ecdsa crate for their current policies/impacted functions. I'd like a function which just works and is guaranteed to work in this context. While I do not believe the ecdsa crate's policies are expected to change, I'll note they require additional code around their recovery in order for their recovery to be used as ecrecover (justifying the definition of a dedicated ecrecover function regardless).
Additional context
No response
The text was updated successfully, but these errors were encountered:
Component
consensus, eips, genesis
Describe the feature you would like
alloy itself exposes recover_signer yet not a 1:1 implementation of ecrecover.
ethers-rs did expose a recover function, internally calling the ecdsa crate.
ecdsa doesn't explicitly implement ecrecover, as defined in Ethereum. Please note their policy on low/high s values: RustCrypto/elliptic-curves#991
This did break an EVM dependent on it (which bubbled up into foundry IIRC).
While I could implement ecrecover myself based on ecdsa, I do not want to have to review the ecdsa crate for their current policies/impacted functions. I'd like a function which just works and is guaranteed to work in this context. While I do not believe the ecdsa crate's policies are expected to change, I'll note they require additional code around their recovery in order for their recovery to be used as ecrecover (justifying the definition of a dedicated ecrecover function regardless).
Additional context
No response
The text was updated successfully, but these errors were encountered: