Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] state changeset arg breaks compatibility with certain endpoints #761

Closed
klkvr opened this issue May 21, 2024 · 1 comment · Fixed by #763
Closed

[Bug] state changeset arg breaks compatibility with certain endpoints #761

klkvr opened this issue May 21, 2024 · 1 comment · Fixed by #763
Assignees
Labels
bug Something isn't working

Comments

@klkvr
Copy link
Contributor

klkvr commented May 21, 2024

Component

network, json-rpc, rpc

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

State changeset arg is not a part of specification, and is not supported by all client implementations. currently it is always being included as a third argument in eth_call which is incorrect for some of the endpoints

ref foundry-rs/foundry#7954 and foundry-rs/foundry#7943

we should probably only include it into the request payload if it's not empty

@klkvr klkvr added the bug Something isn't working label May 21, 2024
@prestwich prestwich self-assigned this May 21, 2024
@DaniPopes
Copy link
Member

#763 did not fix this. Fixed with #778.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants